Allows extraObjects to be defined as either a list or dictionary. List objects are the more typical use case, however can't span multiple values files while dictionaries can. So if you have two files values (one encrypted and one not) and need to provide a Secret object, you're forced to move all extraObjects to the encrypted file. With a dictionary object you wouldn't have to do that.
[x] Title matches the required conventional commits format, see here
Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
[x] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
[x] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
[x] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
TheRealNoob
commented
2 weeks ago
What this PR does / why we need it:
Allows
extraObjectsto be defined as either a list or dictionary. List objects are the more typical use case, however can't span multiple values files while dictionaries can. So if you have two files values (one encrypted and one not) and need to provide a Secret object, you're forced to move all extraObjects to the encrypted file. With a dictionary object you wouldn't have to do that.Which issue(s) this PR fixes: None
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR