grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
23.49k stars 3.4k forks source link

fix: querier address in SingleBinary mode #13297

Closed wrdls closed 3 months ago

wrdls commented 3 months ago

What this PR does / why we need it:

Fix loki.querierAddress helper distributed check.

The current if statement effectively checks if the string is non-empty.

Which issue(s) this PR fixes: Fixes #12772 Fixes #12586

Special notes for your reviewer:

Checklist

wrdls commented 3 months ago

Hi @slim-bean. Thanks for reviewing this.

Could you update it (likely just the version number needs a bump)

It's not clear to me what needs to happen. Do you mean the version in Chart.yaml?