grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
22.73k stars 3.31k forks source link

fix(blooms): Fix panic in bloom gateway #13303

Closed chaudum closed 1 week ago

chaudum commented 1 week ago

What this PR does / why we need it:

The slice of block queriers can contain nil values, which causes nip pointer dereference when calling Close() on them.

The regression was introduced with PR #13288

Checklist

chaudum commented 1 week ago

LGTM as a hotfix! Can we avoid inserting nil values into the slice instead as a long-term fix or is there a good reason for doing that?

There is a reason why we have nil values in the slice: The block queriers are obtained from the bloom store based on a list of block refs, and the result list needs to match the order of the input list. nil values indicate that a block is not available for a given block ref.