Closed chaudum closed 1 week ago
LGTM as a hotfix! Can we avoid inserting nil values into the slice instead as a long-term fix or is there a good reason for doing that?
There is a reason why we have nil
values in the slice: The block queriers are obtained from the bloom store based on a list of block refs, and the result list needs to match the order of the input list. nil
values indicate that a block is not available for a given block ref.
What this PR does / why we need it:
The slice of block queriers can contain
nil
values, which causes nip pointer dereference when callingClose()
on them.The regression was introduced with PR #13288
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR