grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
22.71k stars 3.3k forks source link

fix(helm): Avoid scraping metrics from gateway pod #13350

Open Skaronator opened 3 days ago

Skaronator commented 3 days ago

What this PR does / why we need it:

Rename the nginx port name to avoid beeing scraped by the ServiceMonitor: https://github.com/grafana/loki/blob/91a34868db61f2cf4299d618c2e48885ff0a705e/production/helm/loki/templates/monitoring/servicemonitor.yaml#L32-L33

Which issue(s) this PR fixes: Fixes #13201

Special notes for your reviewer:

Checklist

CLAassistant commented 3 days ago

CLA assistant check
All committers have signed the CLA.

Skaronator commented 3 days ago

I am not sure if we need to do a major version bump. Technically, it's a breaking change, but I don't think it will affect anyone.