grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
23.86k stars 3.45k forks source link

feat(helm): canary can be set as a deployment #13362

Open hervenicol opened 4 months ago

hervenicol commented 4 months ago

What this PR does / why we need it:

By default, canary was created as a daemonset. Meaning write path was tested for each node of the cluster. However, when you have one loki on a cluster, but the clients sending logs run on some other clusters, it does not make much sense anymore to have that many canary pods. So, if you just want to test the write path works, a deployment with a few canary pods is enough.

This PR adds the option to deploy canary pods as a deployment instead of a daemonset.

Special notes for your reviewer:

Checklist

QuentinBisson commented 2 months ago

@MichelHollands I know we need to rebase this to fix conflicts but what do you think about the underlying PR?

QuentinBisson commented 1 month ago

hey @chaudum do you think we could have a review on this PR from the team?