feat: Use prefixed WAL storage path in Object Storage - Githubissues

grafana / loki

Like Prometheus, but for logs.

https://grafana.com/loki

GNU Affero General Public License v3.0

22.75k stars 3.31k forks source link

feat: Use prefixed WAL storage path in Object Storage #13377

Closed benclive closed 2 days ago

benclive commented 4 days ago

What this PR does / why we need it:

Sets the name for the stored WAL segment to be a ULID with a prefix used only by this ingester.
This will need more work as the entropy source is not concurrent safe & will probably collide with another instance of the ingester, but I wanted to namespace the object path before trying this code against a real object store to avoid polluting it.

Which issue(s) this PR fixes: Partial implements https://github.com/grafana/loki-private/issues/1020

cyriltovena commented 3 days ago

Merge at your will !