search

grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
23.89k stars 3.45k forks source link

Helm Linting error caused by commented out values for bucketNames #13564

Open earimont-ib opened 3 months ago

earimont-ib commented 3 months ago

https://github.com/grafana/loki/blob/46de4c1bc839ef682798bec5003123f7d5f4404b/production/helm/loki/values.yaml#L312-L318

template: loki/charts/loki/templates/write/statefulset-write.yaml:37:6: executing "loki/charts/loki/templates/write/statefulset-write.yaml" at <include "loki.commonStorageConfig" .>: error calling include: template: loki/charts/loki/templates/_helpers.tpl:221:19: executing "loki.commonStorageConfig" at <$.Values.loki.storage.bucketNames.chunks>: nil pointer evaluating interface {}.chunks

prasoon-pxc commented 3 months ago

same for me, is there any update?

jemag commented 3 months ago

loki chart does not render with default values.

The usual practice is to be able to template the chart without any changes to values. In the context of Loki, that might not make for the most realistic end-result, but perhaps best to keep up de facto standard.

In this case, it could potentially be defining loki.storage.bucketNames as {} and loki.useTestSchema as true in the default values.

geniass commented 3 months ago

The defaults for single binary mode are broken because it defaults to S3 storage. I had to add this to the loki section (note changed the schema_config object_store to filesystem):

schemaConfig:
  configs:
    - from: 2024-04-01
      store: tsdb
      object_store: filesystem
      schema: v13
      index:
        prefix: loki_index_
        period: 24h

storage:
  type: filesystem