search

grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
23.39k stars 3.39k forks source link

Helm chart values YAML should quote date #14126

Open whatnick opened 1 week ago

whatnick commented 1 week ago

Describe the bug The documented values in for Helm use an unquoted string as date. Some deployment tooling such as flux can roundtrip this into an ISO formatted string which Loki cannot parse from the config.

Mitigation would be quote the string in the sample YAML values or Loki config parser modified to support ISO time.

To Reproduce Steps to reproduce the behavior:

  1. Deploy Loki using stock values on cluster running flux Gitops using a Helm Release resource.

Expected behavior Chart deploys and Loki pods start

Environment:

Screenshots, Promtail config, or terminal output

failed parsing config: /etc/loki/config/config.yaml: parsing time "2024-04-01T00:00:00Z": extra text: "T00:00:00Z". Use -config.expand-env=true flag if you want to expand environment variables in your file
thatMacAdmin commented 1 day ago

I was also affected by this bug. It took me a couple days to figure out why. The documentation should be corrected.