grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
23.96k stars 3.46k forks source link

chore: Clean up unused bloom filter related code #14183

Closed chaudum closed 2 months ago

chaudum commented 2 months ago

What this PR does / why we need it:

This PR tries to eliminate dead code in the bloom package, mainly related to line tokenization.

Special notes for your reviewer:

The binary encoding of the Schema object has been kept "backwards" compatible. Should we drop that?

Checklist

rfratto commented 2 months ago

The binary encoding of the Schema object has been kept "backwards" compatible. Should we drop that?

This would only impact our existing deployment, right? It's very little overhead so I don't think it matters, but it might be nice to remove it now while we have a chance as long as it wouldn't cause too much pain.

chaudum commented 2 months ago

The binary encoding of the Schema object has been kept "backwards" compatible. Should we drop that?

This would only impact our existing deployment, right?

Right.

It's very little overhead so I don't think it matters, but it might be nice to remove it now while we have a chance as long as it wouldn't cause too much pain.

Ok, let's remove it. It means that existing V3 blocks cannot be read any more and should be deleted from object storage.