Closed chaudum closed 2 months ago
The binary encoding of the Schema object has been kept "backwards" compatible. Should we drop that?
This would only impact our existing deployment, right? It's very little overhead so I don't think it matters, but it might be nice to remove it now while we have a chance as long as it wouldn't cause too much pain.
The binary encoding of the Schema object has been kept "backwards" compatible. Should we drop that?
This would only impact our existing deployment, right?
Right.
It's very little overhead so I don't think it matters, but it might be nice to remove it now while we have a chance as long as it wouldn't cause too much pain.
Ok, let's remove it. It means that existing V3 blocks cannot be read any more and should be deleted from object storage.
What this PR does / why we need it:
This PR tries to eliminate dead code in the bloom package, mainly related to line tokenization.
Special notes for your reviewer:
The binary encoding of the
Schema
object has been kept "backwards" compatible. Should we drop that?Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR