grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
23.96k stars 3.46k forks source link

feat: Optionally ack writes to kafka on Push requests #14186

Closed benclive closed 1 month ago

benclive commented 2 months ago

What this PR does / why we need it: Adds the ability for the distributor to send requests to multiple places (like the Tee) but also ensuring that all of those requests are successful via tracking their responses.

I'm not particularly sold on the re-use of the Tee model and re-using the tracker object like I have. I'm definitely open to suggestions on alternatives!

Which issue(s) this PR fixes: Fixes https://github.com/grafana/loki-private/issues/1109

Special notes for your reviewer: I'm wondering whether to continue with this approach and convert the existing implementation to it's own Tee so we can manage them in the same way, or if that is overkill.

Checklist