Unmarshal method of LabelAdapter was using yoloString to reference parts of a bytes buffer alloced by grpc lib.
But with release 1.66.0, grpc introduces a new codec that reuses buffers. Referencing parts of these buffers is not safe anymore since these bytes could get cleared or replaced by other messages.
[ ] Title matches the required conventional commits format, see here
Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
[ ] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
[ ] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
[ ] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
What this PR does / why we need it:
Unmarshal method of LabelAdapter was using
yoloStringto reference parts of a bytes buffer alloced by grpc lib. But with release 1.66.0, grpc introduces a new codec that reuses buffers. Referencing parts of these buffers is not safe anymore since these bytes could get cleared or replaced by other messages.Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR