search

grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
23.28k stars 3.37k forks source link

Push official images to a different registry, in addition to Docker Hub #4143

Open onedr0p opened 3 years ago

onedr0p commented 3 years ago

Is your feature request related to a problem? Please describe.

Dockerhub rate limits

Describe the solution you'd like

Push loki and promtail to an additional registry like Quay or GHCR

Additional context

https://github.com/grafana/grafana/issues/27677

cgill27 commented 3 years ago

Google has a pull through caching mirror of dockerhub, use it instead of dockerhub when trying to get around dockerhub rate limits (if not paying for dockerhub account): mirror.gcr.io

onedr0p commented 3 years ago

@cgill27 that doesn't seem to work, it only supports "special" dockerhub images. What "special" means is unclear but maybe only :latest tags.

✖ docker pull mirror.gcr.io/grafana/loki:2.3.0
Error response from daemon: manifest for mirror.gcr.io/grafana/loki:2.3.0 not found: manifest unknown: Failed to fetch "2.3.0" from request "/v2/grafana/loki/manifests/2.3.0".
...
✖ docker pull mirror.gcr.io/grafana/loki:latest
latest: Pulling from grafana/loki
540db60ca938: Pull complete
65d480ecda58: Pull complete
d4b0fb325642: Pull complete
f29bcac4b7d0: Pull complete
24c6616bac1a: Pull complete
f4d1f2c1c39d: Pull complete
947a9928c44d: Pull complete
Digest: sha256:00bdfb87a62b16e91346aeca656538764a5110214e7ce904e833872ffba184c4
Status: Downloaded newer image for mirror.gcr.io/grafana/loki:latest
mirror.gcr.io/grafana/loki:latest
Nemric commented 3 years ago

I had this problem for all of my promtail instances and updates I've created a docker.io/registry container that act as a proxy registry for all my docker hub images, it works great !

stale[bot] commented 2 years ago

Hi! This issue has been automatically marked as stale because it has not had any activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project. A stalebot can be very useful in closing issues in a number of cases; the most common is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, our sincere apologies if you find yourself at the mercy of the stalebot.

onedr0p commented 2 years ago

Still interested in this becoming a reality, thanks!

stale[bot] commented 2 years ago

Hi! This issue has been automatically marked as stale because it has not had any activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project. A stalebot can be very useful in closing issues in a number of cases; the most common is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, our sincere apologies if you find yourself at the mercy of the stalebot.

onedr0p commented 2 years ago

Not stale

MatteoJoliveau commented 2 years ago

Definitely an issue for us as well, especially when running on AWS spot instances (which get frequently rotated, causing re-pulling). GitHub has a free container registry that is available automatically on all public repositories, it should be easy to integrate in your CI workflow.

onedr0p commented 1 year ago

Given the recent dockerhub announcement of removing free team orgs, I'm wondering if the current grafana org will be affected? And if so perhaps this could finally have a high priority?

https://github.com/docker/hub-feedback/issues/2314

remram44 commented 1 month ago

It looks like the grafana account is a "verified publisher", which should make it exempt from rate limits.

danieljkemp commented 1 month ago

It looks like the grafana account is a "verified publisher", which should make it exempt from rate limits.

Removal of rate limiting for developers

Do the rate limits not apply for downloads of the images, or does the wording imply that developers of the verified publisher's org are not subject to rate limits?

remram44 commented 1 month ago

Anyone can download from verified publishers without limit.

For some reason that doesn't apply to "official images", only images from "verified publishers". It's weird but seems reliable for now.