grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
23.83k stars 3.44k forks source link

Implement rule evaluation using read-path components rather than embedded querier #6262

Open dannykopping opened 2 years ago

dannykopping commented 2 years ago

Is your feature request related to a problem? Please describe. Currently, the ruler component uses an embedded querier for its rule evaluations.

Describe the solution you'd like Mimir has implemented "remote rule evaluation" in 2.1.0: https://github.com/grafana/mimir/releases/tag/mimir-2.1.0

Remote ruler mode for improved rule evaluation performance: We've added a remote mode for the Grafana Mimir ruler, in which the ruler delegates rule evaluation to the query-frontend rather than evaluating rules directly within the ruler process itself. This allows recording and alerting rules to benefit from the query parallelization techniques implemented in the query-frontend (like query sharding). Remote mode is considered experimental and is off by default. To enable, see remote ruler.

Describe alternatives you've considered N/A

Additional context N/A

liguozhong commented 2 years ago

👍 This is great. It is very dangerous that the ruler cannot perform concurrency control and current limiting through the querier-scheduler.

stale[bot] commented 2 years ago

Hi! This issue has been automatically marked as stale because it has not had any activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project. A stalebot can be very useful in closing issues in a number of cases; the most common is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, our sincere apologies if you find yourself at the mercy of the stalebot.