Open rabbipigeon opened 2 years ago
The "issue" is that we inherit the Docker service discovery from Prometheus and thus it's labels. So we either add them there or create some workaround here.
I like the idea though. Would you mind creating a related ticket for Prometheus?
@jeschkies made one here https://github.com/prometheus/prometheus/issues/10924
Hi! This issue has been automatically marked as stale because it has not had any activity in the past 30 days.
We use a stalebot among other tools to help manage the state of issues in this project. A stalebot can be very useful in closing issues in a number of cases; the most common is closing issues or PRs where the original reporter has not responded.
Stalebots are also emotionless and cruel and can close issues which are still very relevant.
If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.
We regularly sort for closed issues which have a stale
label sorted by thumbs up.
We may also:
revivable
if we think it's a valid issue but isn't something we are likely
to prioritize in the future (the issue will still remain closed).keepalive
label to silence the stalebot if the issue is very common/popular/important.We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, our sincere apologies if you find yourself at the mercy of the stalebot.
More compose meta labels for docker_sd_configs
Due to the tendancy for Loki docker plugin to hijack containers if Loki is unavailable. ive switched to promtail_sd_configs but it would be nice to have more labels such as
If these would be provided, then we will have all the uses of docker plugin without the chance of it affecting containers life cycle