grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
24k stars 3.46k forks source link

More labels regarding docker-compose for docker_sd_configs #6467

Open rabbipigeon opened 2 years ago

rabbipigeon commented 2 years ago

More compose meta labels for docker_sd_configs

Due to the tendancy for Loki docker plugin to hijack containers if Loki is unavailable. ive switched to promtail_sd_configs but it would be nice to have more labels such as

__meta_docker_compose_project_name
__meta_docker_compose_config_hash
...

If these would be provided, then we will have all the uses of docker plugin without the chance of it affecting containers life cycle

jeschkies commented 2 years ago

The "issue" is that we inherit the Docker service discovery from Prometheus and thus it's labels. So we either add them there or create some workaround here.

I like the idea though. Would you mind creating a related ticket for Prometheus?

rabbipigeon commented 2 years ago

@jeschkies made one here https://github.com/prometheus/prometheus/issues/10924

stale[bot] commented 2 years ago

Hi! This issue has been automatically marked as stale because it has not had any activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project. A stalebot can be very useful in closing issues in a number of cases; the most common is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, our sincere apologies if you find yourself at the mercy of the stalebot.