search

grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
23.9k stars 3.45k forks source link

Fix helm chart testing and deployment #852

Open slim-bean opened 5 years ago

slim-bean commented 5 years ago

Currently we push (and overwrite) the helm chart with every push to master, @steven-sheehy had introduced a change to address this in #677 but I closed this issue as the original PR is now fairly diverged from master with the latest round of changes to the build and release process.

The issue around Helm charts still exists, and also there is a chicken/egg problem with helm chart testing during release prep: When you create a PR with the necessary Helm image version changes for the next version, it will always fail CI because the new image doesn't exist until after the release is performed.

For 0.2.0 we worked around this by performing the release and then doing a fast-following PR to update the helm charts, however, this results in the v0.2.0 tag not including the updated helm charts.

In a perfect world I would like to have the git release tag also include the helm/ksonnet configs updated with the release version but we need to figure out how to get the release prep PR submitted and merged without CI tripping over the helm test.

Ideas welcome!

/cc @steven-sheehy @sh0rez

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

rfratto commented 5 years ago

Opening this since we mention it in the docs as waiting for a fix.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.