search

grafana / loki

Like Prometheus, but for logs.
https://grafana.com/loki
GNU Affero General Public License v3.0
23.92k stars 3.45k forks source link

No longer possible to add labels to all loki created objects in kubernetes with the new helm chart. #8819

Open rubenvw-ngdata opened 1 year ago

rubenvw-ngdata commented 1 year ago

Is your feature request related to a problem? Please describe. The problem is that we used to set labels on all deployed kubernetes objects (services, service accounts, etc) with the loki helm chart v 2.16.0, but after migrating to 4.8.0 this is no longer possible. We use these labels to label all objects that are part of the deployment for the same environment.

Describe the solution you'd like It would be interesting if we could add some general labels everywhere where the template uses include "loki.labels". e.g. by adding Values.loki.genericLabels. Now it is only possible to add labels to pods with Values.loki.podLabels.

Describe alternatives you've considered As an alternative I could add the labels with kubectl command after the deployment, but that would complicate the loki deployment.

Additional context Not required, should be clear with the description.

Rohlik commented 1 month ago

It's very much the same issue as for Mimir - https://github.com/grafana/mimir/issues/9067. I would love to see this implemented and not do some workarounds instead 😔.