search

grafana / metrictank

metrics2.0 based, multi-tenant timeseries store for Graphite and friends.
GNU Affero General Public License v3.0
623 stars 104 forks source link

Multiple shards on same hardware node #2003

Closed deniszh closed 2 years ago

deniszh commented 3 years ago

Describe the bug When I try to deploy more then one shard of Metrictank on same hardware node it's not really working because of conflict of node name in memberlist, e.g.

2021/09/10 10:16:46 [ERR] memberlist: Conflicting address for worker999. Mine: 10.17.14.111:20380 Theirs: 10.17.14.111:23425

worker999 is a hostname.

Helpful Information Metrictank Version: v1.1-168-g2833b60

Maybe it's possible to distinguish node name through config?

deniszh commented 3 years ago

Looks like config change can't hel here, but code change is quite trivial - https://github.com/deniszh/metrictank/commit/b00e8b52825806509c0013f638482408a80c4d52 Looks like that enough - it's resolving name conflict, everything else working as usual.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.