search

grafana / metrictank

metrics2.0 based, multi-tenant timeseries store for Graphite and friends.
GNU Affero General Public License v3.0
623 stars 104 forks source link

Move timezone and utils to separate package #2015

Closed pub-djedruszczak closed 2 years ago

pub-djedruszczak commented 2 years ago

This PR moves the api.timeZone var and certain utilities from the api package into a new tz package. The GetFromTo function is exported for use in a future native implementation of the linearRegression function.

Some encapsulation of the api.timeZone var (now tz.TimeZone) is lost so that it can continue to be set from api.ConfigSetup, maintaining backwards compatibility. The api package is highly dependent on the expr package, making the export of api.getFromTo from the api package for use in native function implementations (the expr package) difficult due to import cycles.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

robert-milan commented 2 years ago

I'll be taking over reviewing this for now

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

robert-milan commented 2 years ago

Can we get @djedruszczak to agree to the CLA?

pub-djedruszczak commented 2 years ago

Can we get @djedruszczak to agree to the CLA?

Signed!