search

grafana / mimir-prometheus

Apache License 2.0
35 stars 9 forks source link

Fix flaky tsdb test TestQueryHistogramFromBlocksWithCompaction #375

Open bboreham opened 1 year ago

bboreham commented 1 year ago

Proposal

I have observed tsdb tests fail, without much description of what exactly went wrong: https://github.com/grafana/mimir-prometheus/actions/runs/3603613156/jobs/6072026196 (There is no specific FAIL: message naming one test)

However I have noticed that tests such as TestQueryHistogramFromBlocksWithCompaction allocate several GB, so the failure could be an OOM (which is never reported by go test).

bboreham commented 1 year ago

Believed fixed by https://github.com/prometheus/prometheus/pull/11674