Update to upstream 64a9abb8be (`LabelValuesFor` signature change)

grafana / mimir-prometheus

Apache License 2.0

35 stars 9 forks source link

Update to upstream 64a9abb8be (`LabelValuesFor` signature change) #651

Closed colega closed 4 months ago

colega commented 4 months ago

This brings the changes from upstream up to 64a9abb8be which includes changes to LabelValuesFor method: https://github.com/prometheus/prometheus/pull/14280

This intentionally doesn't update to latest main, which will have more changes because of the compactor interface refactor: https://github.com/prometheus/prometheus/pull/14143

CLAassistant commented 4 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 8 committers have signed the CLA.

:white_check_mark: colega
:white_check_mark: bboreham
:white_check_mark: freak12techno
:white_check_mark: roidelapluie
:x: rgroothuijsen
:x: parnavh
:x: SuperQ
:x: Ranveer777
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

colega commented 4 months ago

This introduces a performance regression in LabelNamesFor fixed later in https://github.com/prometheus/prometheus/commit/5efc8dd27b6e68d5102b77bc708e52c9821c5101

So this shouldn't go into the Mimir's weekly release without that.