search

grafana / mimir-proxies

Proxies to help you ingest your metrics into Grafana Mimir.
GNU Affero General Public License v3.0
76 stars 6 forks source link

[build] Error 1 #206

Open wademorris opened 5 days ago

wademorris commented 5 days ago

Hello!

I am receiving a build error 1 when trying to build the binary. github.com/grafana/mimir-proxies/pkg/remoteread pkg/remoteread/api.go:142:30: cannot use v1api (variable of type "github.com/prometheus/client_golang/api/prometheus/v1".API) as API value in struct literal: "github.com/prometheus/client_golang/api/prometheus/v1".API does not implement API (wrong type for method LabelNames) have LabelNames("context".Context, []string, "time".Time, "time".Time, ..."github.com/prometheus/client_golang/api/prometheus/v1".Option) ([]string, "github.com/prometheus/client_golang/api/prometheus/v1".Warnings, error) want LabelNames("context".Context, []string, "time".Time, "time".Time) ([]string, "github.com/prometheus/client_golang/api/prometheus/v1".Warnings, error) make: *** [build] Error 1

Any ideas? TY!

Wade

alexgreenbank commented 5 days ago

Looks like this changed in prometheus/client_golang 1.20.0 (specifically https://github.com/prometheus/client_golang/pull/1544/files).

Not sure why our dependabot didn't warn us of this, we'll investigate.

alexgreenbank commented 5 days ago

Does the branch in https://github.com/grafana/mimir-proxies/pull/207 work for you?

wademorris commented 5 days ago

yep!!! bash ./scripts/compile_commands.sh Succesfully built datadog-proxy-writes into dist/datadog-proxy-writes Succesfully built graphite-proxy-writes into dist/graphite-proxy-writes Succesfully built mimir-whisper-converter into dist/mimir-whisper-converter