search

grafana / mimir

Grafana Mimir provides horizontally scalable, highly available, multi-tenant, long-term storage for Prometheus.
https://grafana.com/oss/mimir/
GNU Affero General Public License v3.0
4.14k stars 532 forks source link

Samples in the future should not be validated against chunk-store grace period #178

Open bboreham opened 3 years ago

bboreham commented 3 years ago

Describe the bug Samples are validated here: https://github.com/grafana/mimir/blob/21ab3294257eb3a0dd13eb153ff1542718b72a0c/pkg/util/validation/validate.go#L120-L121 CreationGracePeriod is defined in terms of tables, which a user may find confusing when using block storage with no tables: https://github.com/grafana/mimir/blob/21ab3294257eb3a0dd13eb153ff1542718b72a0c/pkg/util/validation/limits.go#L143-L144

Expected behavior We should have a setting for how far in the future samples are allowed, independent of table creation.

pracucci commented 1 year ago

The CLI flag description was improved in this PR: https://github.com/grafana/mimir/pull/1287