Helm <> Jsonnet Differences: Environment Vars

grafana / mimir

Grafana Mimir provides horizontally scalable, highly available, multi-tenant, long-term storage for Prometheus.

https://grafana.com/oss/mimir/

GNU Affero General Public License v3.0

4.17k stars 535 forks source link

Helm <> Jsonnet Differences: Environment Vars #2213

Open Logiraptor opened 2 years ago

Logiraptor commented 2 years ago

Found during #2067

Environment vars

[ ] Jsonnet sets POD_IP on the alertmanager
[ ] Jsonnet sets JAEGER_REPORTER_MAX_QUEUE_SIZE on the querier

pracucci commented 2 years ago

Jsonnet sets POD_IP on the alertmanager

This is coming from https://github.com/grafana/cortex-jsonnet/pull/394. The POD_IP environement variable was used to set -alertmanager.cluster.listen-address, but we're not using it anymore (that config option doesn't even exist anymore in Mimir). I think we should remove POD_IP from Jsonnet.

@stevesg @gotjosh Any objection?