grafana / mimir

Grafana Mimir provides horizontally scalable, highly available, multi-tenant, long-term storage for Prometheus.
https://grafana.com/oss/mimir/
GNU Affero General Public License v3.0
4.14k stars 533 forks source link

Helm: istio sidecar compatible make bucket jobs for MinIO #2846

Open krajorama opened 2 years ago

krajorama commented 2 years ago

Describe the bug

Cannot install mimir-distributed with MinIO without error when istio sidecar injection is enabled , because minio make bucket job is stuck in notReady state.

This issue is low prio.

To Reproduce

Steps to reproduce the behavior:

  1. Enable istio auto sidecar injection
  2. helm install mimir-distributed chart - default values

Expected behavior

helm install should finish with success

Environment

Additional Context

Workaround for non-strict istio mode:

minio:
  makeBucketJob:
    podAnnotations:
      sidecar.istio.io/inject: "false"

We should come up with some workaround for the strict mode of istio, where we cannot turn off the sidecar injection.

https://github.com/istio/istio/issues/11045 https://github.com/kubernetes/enhancements/issues/2872

bilsch-nice commented 8 months ago

I tried this workaround and it does not appear to work anymore. When I looked at the values.yaml there is no podAnnotations section anymore