search

grafana / mimir

Grafana Mimir provides horizontally scalable, highly available, multi-tenant, long-term storage for Prometheus.
https://grafana.com/oss/mimir/
GNU Affero General Public License v3.0
4.15k stars 535 forks source link

Ruler: Alertmanager ring base SD #3900

Open FUSAKLA opened 1 year ago

FUSAKLA commented 1 year ago

Hi, just wondering if you were thinking about support for ring based service discovery of Alertmanager instances from ruler? Right now you have to set up a balancer for AM and set it to the ruler, but it would be easier the same way as added with scheduler recently to use the ring.

If you were open to such addition, I'd give it a shot and implement it.

FUSAKLA commented 1 year ago

Another idea I got today is writing an adapter from ring to XDS that could be used in envoy for example to balance traffic to distributors and could be used also for the alertmanager balancing :thinking:

pracucci commented 1 year ago

if you were thinking about support for ring based service discovery of Alertmanager instances from ruler?

I'm up to it. I was sure I had open a similar issue back in time, but I can't find it, so probably I've just thought about it without opening an issue.

Following query-scheduler implementation (also to keep consistency) is a good approach.

ying-jeanne commented 1 year ago

@pracucci I am interested in implement ring discovery of alert manager in ruler, could I start it?