Open QuentinBisson opened 6 months ago
yeah i think it makes sense to remove those panels by default in the rendered dashboards. They are removed via $._config.gateway_enabled
. I believe this is the config that's used for the config default dashboards https://github.com/grafana/mimir/blob/9090af52a8e104c37bb4da975bbefbf5185458cc/operations/mimir-mixin/mixin-compiled.libsonnet setting gateway_enabled: false
in that file should do the job.
Hi @dimitarvdimitrov , I would like to work on this.
Describe the bug
The networking overview dashboards renders the number of inflight request for the mimir gateway https://github.com/grafana/mimir/blob/1e903e4620504a265d49ccee621f09e17b3a18f8/operations/mimir-mixin/dashboards/overview-networking.libsonnet#L9 but the gateway(when using the non enterprise gateway which is nginx) will never expose the metrics used in those panel:
cortex_inflight_requests
cortex_tcp_connections
andcortex_tcp_connections_limit
Should those panels be removed for the gateway in the case that it uses nginx?
On that note, the rollout dashboard should probably be removable from the mixins as it's main use case it for the enterprise gateway
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Environment
Additional Context