grafana / mimir

Grafana Mimir provides horizontally scalable, highly available, multi-tenant, long-term storage for Prometheus.
https://grafana.com/oss/mimir/
GNU Affero General Public License v3.0
4.15k stars 534 forks source link

Allow to override cluster_name in mimir-distributed helm chart by using mimir.structuredConfig #8866

Closed maikel-09 closed 1 month ago

maikel-09 commented 3 months ago

Is your feature request related to a problem? Please describe.

cluster_name is used for validating the GEM license, Right now the Release.Name value is used to set the cluster_name in the values.yaml.

Describe the solution you'd like

    mimir:
      structuredConfig:
        cluster_name: "CLUSTERXYZ"

Describe alternatives you've considered

Alternatives are:

benoitschipper commented 3 months ago

Totally Agree, would make it more flexible :) +1

narqo commented 3 months ago

I don't follow, what is the issue here. Does it not work, when you override it via the structuredConfig?

The following renders the mimir.yaml with cluster_name overwritten:

% helm template test-mimir . --set 'mimir.structuredConfig.cluster_name=the-cluster'

apiVersion: v1
kind: ConfigMap
metadata:
  name: test-mimir-config
  labels:
    helm.sh/chart: mimir-distributed-5.5.0-weekly.301
    app.kubernetes.io/name: mimir
    app.kubernetes.io/instance: the-mimir
  ···
data:
  mimir.yaml: |
    ···
    cluster_name: the-cluster
narqo commented 1 month ago

Please, reopen the issue and provide more details if this still doesn't work for you.