grafana / mimir

Grafana Mimir provides horizontally scalable, highly available, multi-tenant, long-term storage for Prometheus.
https://grafana.com/oss/mimir/
GNU Affero General Public License v3.0
4.14k stars 532 forks source link

copyblocks: add option to bypass duration check for no-compact blocks #9439

Closed andyasp closed 1 month ago

andyasp commented 1 month ago

What this PR does

Adds a flag to bypass the block duration check in copyblocks for blocks marked as no-compact.

It's a common pattern to use min-block-duration with the intent of targeting blocks that are fully compacted. This can miss blocks that are marked as no-compact that have a shorter duration. This flag makes it easier to not miss those blocks.

Which issue(s) this PR fixes or relates to

Fixes N/A

Checklist

narqo commented 1 month ago

The CHANGELOG has just been cut to prepare for the next release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG.md document. Thanks!

andyasp commented 1 month ago

I struggled with the name as well. Open to ideas for it and I'll hold off while trying to think of something myself. -disable-no-compact-validation doesn't quite work because this is only for the duration check specifically.