grafana / mimir

Grafana Mimir provides horizontally scalable, highly available, multi-tenant, long-term storage for Prometheus.
https://grafana.com/oss/mimir/
GNU Affero General Public License v3.0
4.17k stars 535 forks source link

fix incorrectly set query frontend codec lookback delta #9984

Closed francoposa closed 4 days ago

francoposa commented 4 days ago

What this PR does

This appears to have been a bug ever since I plugged the setting into the prometheus codec.

It should be set directly from the querier engine config. The frontend v2 config also sets it from the original source, the querier engine config. Since this codec module gets initialized before the frontend v2 config setting does, by referencing the uninitialized config value, it always ends up zero instead of the real value.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist