search

grafana / otel-profiling-java

otel profling integration for java
Apache License 2.0
24 stars 5 forks source link

otelpyroscope link in README.md needs to be updated #3

Open vasigorc opened 1 year ago

vasigorc commented 1 year ago

The otelpyroscope link from the README file currently yields a 404 page.

I wanted to create a PR to fix this:

diff --git a/README.md b/README.md
index 7708ab0..a7a96f0 100644
--- a/README.md
+++ b/README.md
@@ -8,7 +8,7 @@ link traces with the profiling data, and find specific lines of code related to
 * Because of how sampling profilers work, spans shorter than the sample interval may not be captured. By default pyroscope CPU profiler probes stack traces 100 times per second, meaning that spans shorter than 10ms may not be captured.

-Java code can be easily instrumented with [otelpyroscope](https://github.com/pyroscope-io/pyroscope-java/tree/main/otelpyroscope) package -
+Java code can be easily instrumented with [otelpyroscope](https://github.com/pyroscope-io/otel-profiling-java/tree/main/src/main/java/io/otel/pyroscope) package -
 a `OpenTelemetry` implementation, that annotates profiling data with span IDs which makes it possible to filter
 out profile of a particular trace span in Pyroscope:

diff --git a/gradle.properties b/gradle.properties
index c260f33..4d5c931 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -1,2 +1,2 @@
 pyroscope_version=0.10.1
-otel_profiling_version=0.10.1.3
+otel_profiling_version=0.10.1.4

but I don't have permissions to read from this repository:

ERROR: Permission to pyroscope-io/otel-profiling-java.git denied to vasigorc.