search

grafana / otel-profiling-java

otel profling integration for java
Apache License 2.0
22 stars 5 forks source link

traces and profiling correlation #4

Open mvkrishna86 opened 10 months ago

mvkrishna86 commented 10 months ago

Is this repo still valid? I am able to send the profile data, but not sure how to correlate traces and profiling data.

korniltsev commented 10 months ago

The repo is valid with some exceptions:

  1. There's a known bug when spans are started on one thread and closed on a different one. https://github.com/grafana/pyroscope-java/issues/101 https://github.com/grafana/pyroscope-java/issues/70
  2. exemplars are not implemented yet in grafana pyroscope. They were implemented in og pyroscope
mvkrishna86 commented 10 months ago

I am not trying to use exemplars. Span to Profile or Profile to span correlation would be a good start for me. Can you guide me how to do this configuration for Pyroscope and Tempo datasources in grafana?

Rperry2174 commented 6 months ago

this was merged a couple weeks ago and will be in the upcoming release of grafana! https://github.com/grafana/grafana/pull/77537

still need to fix some of the bugs @korniltsev mentioned but depending on your use case these may not be a blocker for you

hadesy commented 3 months ago

The repo is valid with some exceptions:

  1. There's a known bug when spans are started on one thread and closed on a different one. Improve contextID integration pyroscope-java#101 Intermittent java.lang.AssertionError: null appearing in calls to Pyroscope pyroscope-java#70
  2. exemplars are not implemented yet in grafana pyroscope. They were implemented in og pyroscope

@korniltsev I came across the cross-thread span issue in pyroscope-java (https://github.com/grafana/pyroscope-java/issues/70) and was wondering about the progress on that front. Any updates or rough timelines on a fix? Also, are there any temporary fixes or workarounds we might use in the meantime?

korniltsev commented 3 months ago

I'm not aware of priorities. cc @Rperry2174