grafana / plugin-tools

Create Grafana plugins with ease.
https://grafana.com/developers/plugin-tools/
Apache License 2.0
57 stars 28 forks source link

Plugin E2E: Rename getByTestIdOrAriaLabel to getByGrafanaSelector #832

Closed sunker closed 5 months ago

sunker commented 5 months ago

What this PR does / why we need it:

This PR introduces deprecates the getByTestIdOrAriaLabel and introduces a getByGrafanaSelector method instead. The getByGrafanaSelector method works in the same way as the getByTestIdOrAriaLabel method - it's just a name change to make its purpose a bit more clear. The getByGrafanaSelector is marked as deprecated, but will still work until we release 1.0.0 of the plugn-e2e package.

Which issue(s) this PR fixes:

Fixes https://github.com/grafana/plugin-tools/issues/825

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @grafana/create-plugin@4.5.0-canary.832.708efb9.0 npm install @grafana/plugin-e2e@0.25.0-canary.832.708efb9.0 # or yarn add @grafana/create-plugin@4.5.0-canary.832.708efb9.0 yarn add @grafana/plugin-e2e@0.25.0-canary.832.708efb9.0 ```
github-actions[bot] commented 5 months ago

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release. NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

grafana-plugins-platform-bot[bot] commented 5 months ago

:rocket: PR was released in @grafana/plugin-e2e@0.26.0 :rocket: