grafana / plugin-tools

Create Grafana plugins with ease.
https://grafana.com/developers/plugin-tools/
Apache License 2.0
55 stars 27 forks source link

Plugin E2E: Remove custom selector engine #859

Closed sunker closed 3 months ago

sunker commented 3 months ago

What this PR does / why we need it:

This PR removes the custom selector engine and also updates some tsdocs.

Instead of using the custom selector engine, it's recommended to use the getByGrafanaSelector method that is exposed in all Grafana pages.

// instead of this:
page.locator(`selector=data-testid code editor`);
// do this:
panelEditPage.getByGrafanaSelector('data-testid code editor')

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @grafana/plugin-e2e@1.0.0-canary.859.6187444.0 # or yarn add @grafana/plugin-e2e@1.0.0-canary.859.6187444.0 ```
github-actions[bot] commented 3 months ago

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new major release. NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.