grafana / plugin-tools

Create Grafana plugins with ease.
https://grafana.com/developers/plugin-tools/
Apache License 2.0
55 stars 27 forks source link

feat: check compatibility with min version #863

Open sympatheticmoose opened 3 months ago

sympatheticmoose commented 3 months ago

This is just an idea and not verified whether it actually works or not, especially substituting the version within the levitate call.

Its very brittle based on how people could use this field, but may serve as a way to check against whether recent changes break older compatibility.

github-actions[bot] commented 3 months ago

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

❌ This PR cannot be merged until the following issues are addressed:

🏷️ More info about which labels to use
- If the changes only affect the docs website, documentation, or this repository's tooling add the `no-changelog` label. - If there are changes to any of the npm packages src files please choose from one of the following labels: - 🐛 if this PR fixes a bug add the `patch` label - 🚀 if this PR includes an enhancement add the `minor` label - 💥 if this PR includes a breaking change add the `major` label - Optionally, if you would like this PR to publish new versions of packages when it is merged add the `release` label.
CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

sympatheticmoose commented 1 month ago

note to self: missing jq -r '.dependencies.grafanaDependency'

Also copying over from slack w @leventebalogh

I think instead of bash maybe we could use javascript in the step's script, and then we could probably more easily parse the semver string (if it's a semver string) to get the min and max versions? That way we could we could tell if the plugin is compatible with the provided grafana dependency range. (Latest is maybe outside of that range - however it can still be a useful information if it would break with latest)