grafana / plugin-tools

Create Grafana plugins with ease.
https://grafana.com/developers/plugin-tools/
Apache License 2.0
57 stars 31 forks source link

Build: Introduce stricter typechecking #868

Closed jackw closed 5 months ago

jackw commented 5 months ago

What this PR does / why we need it: Noticed that after the move to using tsconfig base configs that we're lacking some useful typescript compiler options to keep our code cleaner. Namely:

    "noUnusedLocals": true,
    "noUnusedParameters": true,

which prevent unused variables and params which I find somewhat confusing when scanning code.

This PR adds a selection of the strictest options to this codebase with the intention that we can eventually use that config to keep our code in a more healthy state.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @grafana/create-plugin@4.6.2-canary.868.05615c5.0 npm install @grafana/plugin-e2e@1.1.1-canary.868.05615c5.0 # or yarn add @grafana/create-plugin@4.6.2-canary.868.05615c5.0 yarn add @grafana/plugin-e2e@1.1.1-canary.868.05615c5.0 ```
github-actions[bot] commented 5 months ago

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release. NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

grafana-plugins-platform-bot[bot] commented 5 months ago

:rocket: PR was released in @grafana/create-plugin@4.6.2, @grafana/plugin-e2e@1.1.1 :rocket: