search

grafana / plugin-tools

Create Grafana plugins with ease.
https://grafana.com/developers/plugin-tools/
Apache License 2.0
58 stars 32 forks source link

Feat: Support eslint v9 #879

Open mikkancso opened 7 months ago

mikkancso commented 7 months ago

Which areas does this feature request relate to

Problem

I'd like to update eslint to version 9 in my plugin. As the migration guide points out, it uses a new configuration format (config migration guide here). This means that in order to migrate to eslint v9, we'd need to migrate the base eslint config file too (.config/.eslintrc) which is controlled by create-plugin.

Solution

Migrate the base eslint config to the new "flat" config format according to their guide, and provide consumers of create-plugin a migration guide, as well.

Note: I have not fully read the eslint v9 migration guide, so there might be other things to do for a successful migration.

Alternatives

No response

Additional context

No response

Are you interested in contributing the solution?

tolzhabayev commented 6 months ago

Hey @mikkancso we will eventually get to this, but given that there is a bigger migration needed to make this work - we will let this sit for a while until there is a clear benefit of moving to eslint v9

mikkancso commented 3 months ago

@tolzhabayev Are you still planning to get to this eventually? This got closed automatically, so I'm just asking if this is still on your radar (no rush).

jordanbertasso commented 1 month ago

Eslint v8.0.0-v8.57.1 was marked as deprecated on 2024-10-05.

https://eslint.org/version-support/

It would be great to see support for this soon!

jackw commented 1 week ago

Once #1277 is merged it will be easy for plugin developers to update their plugins to use version 8 of @grafana/eslint-config which supports the ESlint 9 flat config format. However migrating from the legacy config format to the flat config format is going to be tricky as after doing so running update might put back older dependency versions and the old config file.