search

grafana / plugin-tools

Create Grafana plugins with ease.
https://grafana.com/developers/plugin-tools/
Apache License 2.0
57 stars 31 forks source link

Create Plugins: Use non dev docker image on e2e #883

Closed oshirohugo closed 5 months ago

oshirohugo commented 5 months ago

What this PR does / why we need it:

  1. This PR changes the docker-compose.yaml template to add the possibility to run commands DEVELOPMENT=false docker compose up -d to easily disable the development mode in our docker environment.
  2. Change the e2e ci template to use the non development docker image which is lighter and faster to build than the development one.
📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @grafana/create-plugin@4.8.0-canary.883.4c6a829.0 npm install @grafana/plugin-e2e@1.2.0-canary.883.4c6a829.0 # or yarn add @grafana/create-plugin@4.8.0-canary.883.4c6a829.0 yarn add @grafana/plugin-e2e@1.2.0-canary.883.4c6a829.0 ```
github-actions[bot] commented 5 months ago

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release. NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

sunker commented 5 months ago

@oshirohugo has there been complaints about the e2e being slow in CI? Even though the dev build is heavier, it can be really useful getting the detailed error messages in frontend and backend while troubleshooting issues. So I think we should using the development mode by default. Would be nice to add a note in the CI guide on how to disable development mode though.

oshirohugo commented 5 months ago

@sunker, thank you for your review. There was one complain:

https://raintank-corp.slack.com/archives/C024NL6AEJH/p1711627185261299

It was not specifically about the e2e, it was regarding the time to build the development image in general.

But if you think the benefits of having the development mode is greater, I can make it the default in e2e, no problem. Just let me know :D.

sunker commented 5 months ago

Okay I see. If we could use development mode in e2e, but not install delve that would be great.

grafana-plugins-platform-bot[bot] commented 5 months ago

:rocket: PR was released in @grafana/create-plugin@4.8.0, @grafana/plugin-e2e@1.2.0 :rocket: