grafana / plugin-tools

Create Grafana plugins with ease.
https://grafana.com/developers/plugin-tools/
Apache License 2.0
57 stars 31 forks source link

Docs: Instructions on how to write E2E tests for app plugins #891

Closed mckn closed 4 months ago

mckn commented 5 months ago

What this PR does / why we need it: This PR provides some instructions on how to structure your E2E tests for app plugins. Hopefully it show case two different patterns for improving readability and to make it easier to share logic between tests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: This is a rough draft so feel free to provide bigger text changes that would make it easier to understand the documentation.

github-actions[bot] commented 5 months ago

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

mckn commented 4 months ago

Hi @mckn - Please take a look at my suggestions in my recent commits related to doc style, clarity, and so on. Many of these are related to doc style preference for simple indicative tense and avoidance of gerunds. Let me know if you have any questions.

Love it! There is only one thing that I would like to change. I'm adding a comment with your name to it so we can discuss it in this PR. Hope that is ok 🙏🏻