search

grafana / plugin-tools

Create Grafana plugins with ease.
https://grafana.com/developers/plugin-tools/
Apache License 2.0
55 stars 27 forks source link

PME: Removed dependency on tsquery #902

Closed mckn closed 2 months ago

mckn commented 2 months ago

What this PR does / why we need it: This PR will remove the dependency on tsquery package since it doesn't seem to work properly for both TS4 and TS5. I replaced it with our own implementation to find the correct identifiers that seems to work for both TS4 and TS5.

It would be nice to be able to write some integration tests that check this for different versions of typescript. Opened an issue for doing this.

I have tested the canary version with a plugin using TS4 and it does work 🎉

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @grafana/plugin-meta-extractor@0.0.2-canary.902.bd718a3.0 # or yarn add @grafana/plugin-meta-extractor@0.0.2-canary.902.bd718a3.0 ```
github-actions[bot] commented 2 months ago

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release. NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

grafana-plugins-platform-bot[bot] commented 2 months ago

:rocket: PR was released in @grafana/create-plugin@4.10.2, @grafana/plugin-meta-extractor@0.0.2 :rocket: