search

grafana / plugin-tools

Create Grafana plugins with ease.
https://grafana.com/developers/plugin-tools/
Apache License 2.0
55 stars 27 forks source link

Create plugin: use existing executable name on update #924

Closed oshirohugo closed 1 month ago

oshirohugo commented 1 month ago

What this PR does / why we need it:

When a plugin is updated, it's possible that the executable name being used isn't the same that we suggest/create with our templates, therefore it should be used in case of an update to avoid breaking changes.

Which issue(s) this PR fixes:

Fixes https://github.com/grafana/plugin-tools/issues/907

Special notes for your reviewer:

Even though the executable format used in plugin.json is the same as the ones from supervisord, nothing will be changed in its template because we are not updating plugin.json.

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @grafana/create-plugin@4.10.6-canary.924.aafa349.0 # or yarn add @grafana/create-plugin@4.10.6-canary.924.aafa349.0 ```
github-actions[bot] commented 1 month ago

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release. NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

grafana-plugins-platform-bot[bot] commented 1 month ago

:rocket: PR was released in @grafana/create-plugin@4.11.1, @grafana/plugin-e2e@1.2.1 :rocket: