search

grafana / plugin-tools

Create Grafana plugins with ease.
https://grafana.com/developers/plugin-tools/
Apache License 2.0
55 stars 27 forks source link

Plugin E2E: Fix menuitemclick in Grafana <=9.1.0 #944

Closed sunker closed 1 month ago

sunker commented 1 month ago

What this PR does / why we need it:

This PR changes CI so that e2e tests are targeting a larger range of Grafana versions. Since plugin-e2e APIs are supposed to be compatible with Grafana =>8.5.5, it's important that we cover these older versions in tests.

While doing this, I discovered that clicking menu items doesn't work as expected in versions older than 9.2.0, so adding a fix for that.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

github-actions[bot] commented 1 month ago

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release. NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

sunker commented 1 month ago

I'm surprised that we need to support all the way to 8.5.x in plugin-e2e. 🤔

Yeah it's so we can support enterprise plugins. But should probably drop support for 8.x now that G11 is out the door. I'll discuss with David.

grafana-plugins-platform-bot[bot] commented 1 month ago

:rocket: PR was released in @grafana/plugin-e2e@1.3.2 :rocket: