Closed jackw closed 1 day ago
Nice work Jack, thank you for addressing this one :D. I've tested in Linux and everything is working. I had to do some small changes that maybe you'll address in the final version, but it's good to mention, just in case.
TARGETARCH: ${TARGETARCH:-amd64}
I think we can document this in the final version, the same way we have the other arguments documented.
TARGETARCH
in the dockerfile
and put it after the FROM
statement to make the build work. (Idk if this is related to linux or my docker version Docker version 27.0.2, build 912c1dd
).Nice work Jack, thank you for addressing this one :D. I've tested in Linux and everything is working. I had to do some small changes that maybe you'll address in the final version, but it's good to mention, just in case.
Thanks for taking the time to give me early feedback and provide solutions to the issues I'd created! 🥇 I've now updated the branch based on your suggestions and opened for review.
I've testing and everything is working out of the box! :+1:
:rocket: PR was released in @grafana/create-plugin@4.14.1
:rocket:
What this PR does / why we need it: Draft as requires testing across OS...
This PR changes the docker file and docker compose to not force
amd64
which causes a mismatch between the go arch, docker arch and the host arch causing dlv to fail to work. The linked issue has further investigative info.With the changes in this PR I can successfully connect with dlv using an M2 Macbook.
Which issue(s) this PR fixes:
Fixes #913
Special notes for your reviewer:
To test run the following in terminal...
dlv connect localhost:2345
.break datasource.go:100
.continue
commands and you should see the health check complete successfully.📦 Published PR as canary version:
Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @grafana/create-plugin@4.14.1-canary.990.e4ea168.0 # or yarn add @grafana/create-plugin@4.14.1-canary.990.e4ea168.0 ```