New Validation: Check for backend binaries if backend or alerting declared

grafana / plugin-validator

Tool for validating Grafana community plugins

Apache License 2.0

24 stars 8 forks source link

New Validation: Check for backend binaries if backend or alerting declared #190

Closed academo closed 6 months ago

academo commented 6 months ago

Adds validation for backend, alerting and executable attributes in plugin.json

Closes https://github.com/grafana/plugin-validator/issues/174

Cases Alerting=true and backend=false: error backend=true and executable="": error backend=false and executable=".+": error backend=true, excutable=".+", binaries not found: error backend=true, executable=".+", binaries found: correct

academo commented 6 months ago

LGTM

Not sure if there's anything to consider for bundled plugins with a backend etc

yes. this setup is not considering bundled/nested plugins at all. I'll open a follow up PR to improve that case. I suspect it'll require more changes in the validator.