search

grafana / pyroscope-dotnet

Dotnet profiler
Apache License 2.0
22 stars 4 forks source link

Tracing integration should set `span_name` pprof label #63

Open kolesnikovae opened 2 months ago

kolesnikovae commented 2 months ago

By convention, pyroscope SDKs also propagate span name as a pprof label, which allows building aggregated span profiles. pyroscope-dotnet should do the same

simonswine commented 1 month ago

I gave this a try, but I don't think it is easily achievable, as the processor doesn't know the correct SpanName yet OnStart:

OnStart: Microsoft.AspNetCore.Hosting.HttpRequestIn
OnEnd: GET /bike

The DisplayName is set here https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/9078ceb7a2ae273422412dcb6ae82d50cf7f8a9e/src/Shared/RequestDataHelper.cs#L80-L88