search

grafana / pyroscope-go

This is the golang client integration for Pyroscope
Apache License 2.0
104 stars 19 forks source link

chore(check_golang_profiler_changes): acknowledge new golang profiler changes #135

Open github-actions[bot] opened 4 days ago

github-actions[bot] commented 4 days ago

This PR is created by godeltaprof/compat/cmd/check_golang_profiler_changes/main.go to notify src/runtime/mprof.go or src/runtime/pprof in golang are updated. Please take look at the golang commits and update godeltaprof accordingly if needed. Merge the PR to acknowledge golang runtime changes and state no further actions needed for godeltaprof.

src/runtime/pprof last known 2a98a1849f059ffa94ab23a1ab7d8fa0fd0b48dd current 579eb79f62d92db872d730f5fe954ca2b7dce8ae

commit 579eb79f62d92db872d730f5fe954ca2b7dce8ae
Author: Michael Anthony Knyszek <mknyszek@google.com>
Date:   Mon Oct 28 17:23:40 2024 +0000

    all: skip and fix various tests with -asan and -msan

    First, skip all the allocation count tests.

    In some cases this aligns with existing skips for -race, but in others
    we've got new issues. These are debug modes, so some performance loss is
    expected, and this is clearly no worse than today where the tests fail.

    Next, skip internal linking and static linking tests for msan and asan.

    With asan we get an explicit failure that neither are supported by the C
    and/or Go compilers. With msan, we only get the Go compiler telling us
    internal linking is unavailable. With static linking, we segfault
    instead. Filed #70080 to track that.

    Next, skip some malloc tests with asan that don't quite work because of
    the redzone.

    This is because of some sizeclass assumptions that get broken with the
    redzone and the fact that the tiny allocator is effectively disabled
    (again, due to the redzone).

    Next, skip some runtime/pprof tests with asan, because of extra
    allocations.

    Next, skip some malloc tests with asan that also fail because of extra
    allocations.

    Next, fix up memstats accounting for arenas when asan is enabled. There
    is a bug where more is added to the stats than subtracted. This also
    simplifies the accounting a little.

    Next, skip race tests with msan or asan enabled; they're mutually
    incompatible.

    Fixes #70054.
    Fixes #64256.
    Fixes #64257.
    For #70079.
    For #70080.

    Change-Id: I99c02a0b9d621e44f1f918b307aa4a4944c3ec60
    Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-asan-clang15,gotip-linux-amd64-msan-clang15
    Reviewed-on: https://go-review.googlesource.com/c/go/+/622855
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    TryBot-Bypass: Michael Knyszek <mknyszek@google.com>