search

grafana / pyroscope-go

This is the golang client integration for Pyroscope
Apache License 2.0
101 stars 18 forks source link

Fails to run in Go 1.22 RC1 #90

Closed franchb closed 8 months ago

franchb commented 8 months ago

The code located in the example folder does not execute successfully on Go version 1.22 RC1.

go: finding module for package github.com/grafana/pyroscope-go
go: downloading github.com/grafana/pyroscope-go v1.0.4
go: found github.com/grafana/pyroscope-go in github.com/grafana/pyroscope-go v1.0.4
go: downloading github.com/grafana/pyroscope-go/godeltaprof v0.1.4
# github.com/grafana/pyroscope-go/godeltaprof/internal/pprof
../gopath602117689/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.4/internal/pprof/delta_mutex.go:25:20: undefined: runtime_cyclesPerSecond
../gopath602117689/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.4/internal/pprof/proto.go:400:8: undefined: runtime_expandFinalInlineFrame

https://go.dev/play/p/rFVOk4vZiJQ?v=gotip

korniltsev commented 8 months ago

does it still fail on the latest godeltaprof v0.1.6 ?

korniltsev commented 8 months ago

Im going to close this issue. godeltaprof should be working since 0.1.5 for go 1.22. Please reopen if you find issues.