search

grafana / pyroscope-java

pyroscope java integration
Apache License 2.0
72 stars 31 forks source link

Feat/prio seq multi event profiling #109

Closed tomershafir closed 10 months ago

tomershafir commented 10 months ago

#107 sequential multi event profiling

tomershafir commented 10 months ago

1 made the comment about the dependency a warning log. I think such changes/refactoring that you suggested should be part of a seperate PR that merges the 2 schedulers. Regarding scheduleAtFixRate, the internal pool size is 1, its effectively a single leader thread that sleeps and executes runnables while (true). It is built-in, full featured if needed, and battle tested, I dont see a reason to change. 2 and 3 seems related, maybe future PR 4 yeah, unix/linux C guy :) change to EVENT_ORDER (?) 5 added warning, I think it should be handled in a merge PR

tomershafir commented 10 months ago

done