cyriltovena
commented
1 year ago Correct 4xx should never be retried only 5xx,429 or connection issues.
Closed korniltsev closed 9 months ago
cyriltovena
commented
1 year ago Correct 4xx should never be retried only 5xx,429 or connection issues.
We should not retry on invalid profiles.
2023-09-05 14:40:35.087 [ERROR] Error uploading snapshot: 400 the profile with labels '{name="wall", delta="false", service_name="demo.app", jfr_event="wall", pyroscope_spy="javaspy", region="us-east-1", user="tolyan", qweqwe="asdasd"}' exceeds the samples count limit (max_profile_stacktrace_samples, actual: 16753, limit: 16000)
Maybe we should not retry at all.