search

grafana / pyroscope-java

pyroscope java integration
Apache License 2.0
72 stars 31 forks source link

Support windows as operating system #116

Open bastischubert opened 9 months ago

bastischubert commented 9 months ago

As mentioned in https://github.com/async-profiler/async-profiler#community-supported-builds there is a community supported windows version available for the async profiler.

Maybe we can make windows a first class citizen and also support it in the java agent.

kcrimson commented 6 months ago

looking at releases of async profiler, I don't see continued support for Windows port, we are considering using JFR on Windows to capture profiler data and use it as input for pyroscope. I know this is limited in terms of types of frames it will capture but seems better then nothing ;) We are planning to start work on it if anyone will be interested to use it (and test it :) )

kcrimson commented 6 months ago

Here is the initial implementation which uses JFR recordings, this will collect events using jcmd JFR commands, which works on Windows as well, https://github.com/grafana/pyroscope-java/pull/136.

korniltsev commented 6 months ago

As mentioned in https://github.com/async-profiler/async-profiler#community-supported-builds there is a community supported windows version available for the async profiler.

The link seems broken.

I know Jebtrains / Intellij IDEA has a windows fork, but not sure if it is opensource. Seomeone may consider plugging it in via ProfilerDelegate from #136 . I doubt closed source profiler would be bundled with pyroscope-java so users would have to bundle it themselves.

Async-profiler windows support issue was closed as Not Planned https://github.com/async-profiler/async-profiler/issues/188