grafana / pyroscope-java

pyroscope java integration
Apache License 2.0
72 stars 31 forks source link

OpenJDK CRaC support #141

Open FilipPetrovic0 opened 5 months ago

FilipPetrovic0 commented 5 months ago

I'm using Spring Boot app and I was hoping I could utilize the CRaC project. My app uses this javaagent to send profiling data to server.

In order for CRaC to work, so called checkpoint must be captured, and restored. Before checkpoint is captured, all open connections, sockets and files must be closed. Also, when restoring the checkpoint, every such connection,socket and file must be reopened so the app can perform the same way before the checkpoint was taken.

So the problem here is that pyroscope java agent has an open connection to server where it sends data to, and from the java code, we have no way to close/reopen such connection, meaning capturing the checkpoint is impossible.

The solution would be to make pyroaxopw javaagent CRaC compatible, meaning that the agent can automatically respond to checkpoint capturing/restoring by closing /reopening connections,sockets and files it manages.

That way capturing the checkpoint would be possible.

Other javaagents have the same issue with CRaC and are actively working on it:

https://github.com/elastic/apm-agent-java/issues/2982 https://github.com/newrelic/newrelic-java-agent/issues/1697 https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/10363